Add region support when calling GetClusterCredentials
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuyHadas
approved these changes
Mar 11, 2022
|
Hi @winglot @pawelaugustyn, wondering if you're planning to actively maintain this provider. It's been a big help for @TakeScoop and I'm happy to continue submitting improvements if it's of interest. Otherwise, happy to fork if you're not looking for outside contributions. |
|
I'll second that - it's been a huge help for us too - we're more than happy to help out with maintenance if there's anything we can do. |
|
@bendrucker Sorry for the delays. I had a busy couple of weeks. I have the review and merge processes on my agenda for the beginning of next week. |
|
Quite alright, thanks for the update! |
winglot
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
GetClusterCredentials, users must supply the region where the Redshift cluster is located. Currently, there is no explicit provider configuration field for this input. As noted in #58 (comment), you can useAWS_REGIONto set this.I checked the AWS provider and mirrored its simple field implementation, with no validation:
https://github.com/hashicorp/terraform-provider-aws/blob/19469514cc16736d80ab976aa3178d5aaedbeba8/internal/provider/provider.go#L292-L297